pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael.paquier@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [Sender Address Forgery]Re: pg_(total_)relation_size and partitioned tables
Date: Mon, 29 Jan 2018 12:03:59 +0900
Message-ID: <20180129030359.GA74483@paquier.xyz> (raw)
In-Reply-To: <75294d6a-ff21-58a9-d4e6-56b412ef3ae5@lab.ntt.co.jp>
References: <8ecdd7fb-02d5-4322-526a-e49e2de25064@lab.ntt.co.jp>
	<20180119053958.GD12826@paquier.xyz>
	<7a9c5328-5328-52a3-2a3d-bf1434b4dd1d@lab.ntt.co.jp>
	<20180120101454.GA1311@paquier.xyz>
	<CAKJS1f-mffi=9Kjynns4L4Oc0YN7dJfB=SKyYZH-8bDZ5=q9qg@mail.gmail.com>
	<20180122024407.GA1772@paquier.xyz>
	<45b12bcf-5615-5ac9-1077-19d974087ace@lab.ntt.co.jp>
	<20180126124552.GJ17847@paquier.xyz>
	<CA+TgmoZ=eEPDkk2W+B12Cu_xVeWqys7X=b+2wZu7HD5qWj8jYQ@mail.gmail.com>
	<75294d6a-ff21-58a9-d4e6-56b412ef3ae5@lab.ntt.co.jp>

On Mon, Jan 29, 2018 at 10:08:51AM +0900, Amit Langote wrote:
> On 2018/01/27 3:32, Robert Haas wrote:
>> If it has
>> either partitions or inheritance children, find_all_inheritors will
>> return them.  Otherwise, I think it'll just return the input OID
>> itself.  So I don't quite see, if we're going to add a convenience
>> function here, why wouldn't just define it to return the same results
>> as find_all_inheritors does?
> 
> So if all we're doing is trying to make find_all_inheritors() accessible
> to users through SQL, it makes sense to call it
> pg_get_inheritance_tables() rather than pg_partition_tree_tables().

I was looking again at this stuff this morning, noticing that
find_all_inheritors() is particularly used in
check_default_allows_bound() for partitions, so complaint withdrawn.
The renaming as you propose here looks sensible as well.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (25+ messages)

Message-ID: <20180129030359.GA74483@paquier.xyz>
Permalink:  ../20180129030359.GA74483@paquier.xyz/
Also on:    postgresql.org/message-id/20180129030359.GA74483@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael.paquier@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, david.rowley@2ndquadrant.com, peter.eisentraut@2ndquadrant.com
  Subject: Re: [Sender Address Forgery]Re: pg_(total_)relation_size and partitioned tables
  In-Reply-To: <20180129030359.GA74483@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox