From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Tue, 6 Mar 2018 14:25:28 -0300
Message-ID: <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql> (raw)
In-Reply-To: <880511520351578@web5j.yandex.ru>
Sergei Kornilov wrote:
> Hello, Ildar
> Thanks. I looked ATTACH PARTITION tests and found such checks. If no one is against i will just use in my patch INFO level instead DEBUG1, similarly ATTACH PARTITION code. Updated patch attached.
>
> Or i can rewrite tests to use DEBUG1 level.
You should be able to use an event trigger that raises a message when
table_rewrite is hit, to notify the test driver that a rewrite happens.
(If any DDL that causes a table rewrite fails to trigger the
table_rewrite event correctly, that is a bug.)
ISTM that depending on DEBUG messages is bad because debugging lines
added elsewhere will make your tests fail; and INFO is generally frowned
upon (I, for one, would frown upon an INFO message raised by ALTER
TABLE, for sure.) so let's not do that either.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, sk@zsrv.org, i.musin@postgrespro.ru, sfrost@snowman.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-Reply-To: <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox