pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Fri, 02 Aug 2019 16:02:20 -0400
Message-ID: <24688.1564776140@sss.pgh.pa.us> (raw)
In-Reply-To: <20190802195438.4vuotpz6pdq6r6jg@development>
References: <20190501162021.q7r5cys6uwdb5bsp@alap3.anarazel.de>
	<25570.1556728681@sss.pgh.pa.us>
	<20481181556734692@sas2-80c42a3bfdfe.qloud-c.yandex.net>
	<CAKJS1f9Gaor9+wGWFwaSrm1=N5cPHiM=LGWcCDeuPymC5dkyhw@mail.gmail.com>
	<19795.1556759294@sss.pgh.pa.us>
	<CAKJS1f9dYoeqqOwXW4wqD8tVGNki2AjzOQy=Xo=a_nNAMdYD=g@mail.gmail.com>
	<CAKJS1f-Y2CAV7y_Vay_bmE=oyZPgtm2qXRinozYOJ0SeopjYtw@mail.gmail.com>
	<CAKJS1f_3qanbQSJ8ndkkxCAuHuByJLXR6zuQetOmnmBzWbHg3Q@mail.gmail.com>
	<10303161560180908@sas1-fb8a605c4548.qloud-c.yandex.net>
	<CAKJS1f-MBwNBQWn=pMrhuk=k=9Hmw8BPAC5ryuX0fXdNMqeiFg@mail.gmail.com>
	<20190802195438.4vuotpz6pdq6r6jg@development>

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> I think there's a consensus to change INFO to DEBUG1 in pg12, and then
> maybe imlpement something like VERBOSE mode in the future. Objections?

ISTM the consensus is "we'd rather reduce the verbosity, but we don't
want to give up test coverage".  So what's blocking this is lack of
a patch to show that there's another way to verify what code path
was taken.

> As for the reduction of test coverage, can't we deduce whether a
> constraint was used from data in pg_stats or something like that?

Not sure how exactly ... and we've already learned that pg_stats
isn't too reliable.

			regards, tom lane





view thread (73+ messages)

Message-ID: <24688.1564776140@sss.pgh.pa.us>
Permalink:  ../24688.1564776140@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24688.1564776140@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, david.rowley@2ndquadrant.com, sk@zsrv.org, andres@anarazel.de, robertmhaas@gmail.com, david@pgmasters.net, alvherre@alvh.no-ip.org, sfrost@snowman.net, i.musin@postgrespro.ru
  Subject: Re: using index or check in ALTER TABLE SET NOT NULL
  In-Reply-To: <24688.1564776140@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox