From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: bugfifx: a minor mistake in brin_inclusion.c comment
Date: Mon, 26 Mar 2018 12:11:26 -0300
Message-ID: <20180326151126.6bouh22l4n3ynwcy@alvherre.pgsql> (raw)
In-Reply-To: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com>
Tomas Vondra wrote:
> Hi,
>
> while looking at brin_inclusion.c, I've noticed that the comment about
> INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
> (1 instead of 2). Attached is a simple fix.
Uh, yeah, this is wrong.
> But perhaps it would be better to use the constants in the comment.
I fixed it like this, which seems neater.
Thanks!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tomas.vondra@2ndquadrant.com
Subject: Re: bugfifx: a minor mistake in brin_inclusion.c comment
In-Reply-To: <20180326151126.6bouh22l4n3ynwcy@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox