From: Andres Freund <andres@anarazel.de>
To: Amit Langote <amitlangote09@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Cc: Beena Emerson <memissemerson@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: amul sul <sulamul@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: [HACKERS] Runtime Partition Pruning
Date: Fri, 6 Apr 2018 21:31:08 -0700
Message-ID: <20180407043108.csphvmzyk4gprnze@alap3.anarazel.de> (raw)
In-Reply-To: <CA+HiwqHAKp4=jSQH3WWL4+s3=qWrCaCnBCu-zx4eZ_Tqn6g4DQ@mail.gmail.com>
References: <20180406212507.6ddl76zkhd2ze4p5@alvherre.pgsql>
<20180406212917.zzq5dbmasyt3fwru@alvherre.pgsql>
<CAKJS1f88oG+RPaFCxFf4=omk8KfVZCrWuBHXazag4zGBinagBA@mail.gmail.com>
<CAKJS1f99JnkbOshdV_4zoJZ96DPtKeHMHv43JRL_ZdHRkkVKCA@mail.gmail.com>
<CAKJS1f-42TXEo1DLZ_FXBNiRuJ3=Oy-Z5V8_0WkL0_Ast=9saw@mail.gmail.com>
<CA+HiwqHAKp4=jSQH3WWL4+s3=qWrCaCnBCu-zx4eZ_Tqn6g4DQ@mail.gmail.com>
On 2018-04-07 13:26:51 +0900, Amit Langote wrote:
> On Sat, Apr 7, 2018 at 11:26 AM, David Rowley
> <david.rowley@2ndquadrant.com> wrote:
> > Everything else looks fine from my point of view.
>
> Me too, although I still think having struct names PartitionPruning
> and PartitionRelPruning is going to be a bit confusing. We should
> think about naming the latter to something else. I suggested
> PartitionPruningDispatch(Data), but David doesn't seem to like it.
> Maybe, PartitionPruneState, because it parallels the
> PartitionPruneInfo that comes from the planner for every partitioned
> table in the tree.
I've not followed this thread/feature at all, but I don't find the
comments atop partprune.c even remotely sufficient. Unless there's an
README hidden or such hidden somewhere?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, amitlangote09@gmail.com, david.rowley@2ndquadrant.com, alvherre@alvh.no-ip.org, Langote_Amit_f8@lab.ntt.co.jp, jesper.pedersen@redhat.com, rajkumar.raghuwanshi@enterprisedb.com, memissemerson@gmail.com, robertmhaas@gmail.com, sulamul@gmail.com, dilipbalaut@gmail.com
Subject: Re: [HACKERS] Runtime Partition Pruning
In-Reply-To: <20180407043108.csphvmzyk4gprnze@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox