From: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Cc: simon@2ndquadrant.com
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
Date: Tue, 17 Apr 2018 12:28:58 +0900
Message-ID: <20180417032858.GD4998@paquier.xyz> (raw)
In-Reply-To: <1523881930.3779.37.camel@cybertec.at>
References: <1519917758.6586.8.camel@cybertec.at>
<1523881930.3779.37.camel@cybertec.at>
On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote:
> Now that the dust from the last commitfest is settling, I'll make a second
> attempt to attract attention for this small bug fix.
>
> The original commit was Simon's.
Thanks for the ping.
This was new as of v10, so this cannot be listed as an open item still I
have added that under the section for older bugs, because you are right
as far as I can see.
GetConfigOption is wrong by the way, as restrict_superuser means that
all members of the group pg_read_all_settings can read
GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at
least needs a fix, the variable ought to be renamed as well.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, laurenz.albe@cybertec.at, simon@2ndquadrant.com
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
In-Reply-To: <20180417032858.GD4998@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox