From: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Cc: simon@2ndquadrant.com
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
Date: Fri, 20 Apr 2018 22:58:06 +0900
Message-ID: <20180420135806.GA1562@paquier.xyz> (raw)
In-Reply-To: <1524223306.2480.6.camel@cybertec.at>
References: <1519917758.6586.8.camel@cybertec.at>
<1523881930.3779.37.camel@cybertec.at>
<20180417032858.GD4998@paquier.xyz>
<1524223306.2480.6.camel@cybertec.at>
On Fri, Apr 20, 2018 at 01:21:46PM +0200, Laurenz Albe wrote:
> I agree; here is a patch for that.
Thanks for taking care of that as well this looks fine to me. Note to
committer: this needs to be merged with the first patch actually fixing
the SHOW ALL issue.
All the four core callers of GetConfigOption() actually do not use
restrict_superuser set to true... Modules may use this option, so of
course let's not remove it.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, laurenz.albe@cybertec.at, simon@2ndquadrant.com
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
In-Reply-To: <20180420135806.GA1562@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox