pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Postgres, fsync, and OSs (specifically linux)
Date: Fri, 18 May 2018 21:01:21 -0400
Message-ID: <20180519010121.GV27724@tamriel.snowman.net> (raw)
In-Reply-To: <20180519003210.xehe2kfei5nss4mw@toroid.org>
References: <CAMsr+YF=FfuNCcBJXV4tDsxQQ=Yu5GfhZ-z6iiu+Y4x2MYzX0Q@mail.gmail.com>
	<20180430160945.5s5qfoqryhtmugxl@alap3.anarazel.de>
	<CAMsr+YGsvYmJ0aRuV7zNf-rmi53bzFF8yrsgrNBm9yOY8FYD0g@mail.gmail.com>
	<20180509225555.rmk3azmgrwfwudw5@alap3.anarazel.de>
	<CAMsr+YEcv3gvLHX-gTMnA0Z_YCChJ+rCMTGnx1aQMUFmp4Lvbw@mail.gmail.com>
	<20180517164440.szk6vhbdprcm462a@alap3.anarazel.de>
	<CA+Tgmob0sD3BGo46ZXK4hJw=2NDco10Zsx=rzTMxVXY0kHRvxg@mail.gmail.com>
	<CAFjFpRco+fapy2383raQhzNJRpVivEcSxFBxL5M-4YJZ8T-wbg@mail.gmail.com>
	<20180519002757.GU27724@tamriel.snowman.net>
	<20180519003210.xehe2kfei5nss4mw@toroid.org>

Greetings,

* Abhijit Menon-Sen (ams@2ndQuadrant.com) wrote:
> At 2018-05-18 20:27:57 -0400, sfrost@snowman.net wrote:
> >
> > I don't agree with the general notion that we can't have a function
> > which handles the complicated bits about the kind of error because
> > someone grep'ing the source for PANIC might have to do an additional
> > lookup.
> 
> Or we could just name the function promote_eio_to_PANIC.

Ugh, I'm not thrilled with that either.

> (I understood the objection to be about how 'grep PANIC' wouldn't find
> these lines at all, not that there would be an additional lookup.)

... and my point was that 'grep PANIC' would, almost certainly, find the
function promote_eio_to_panic(), and someone could trivially look up all
the callers of that function then.

Thanks!

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (71+ messages)  latest in thread

Message-ID: <20180519010121.GV27724@tamriel.snowman.net>
Permalink:  ../20180519010121.GV27724@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20180519010121.GV27724@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sfrost@snowman.net, ams@2ndQuadrant.com, ashutosh.bapat@enterprisedb.com, robertmhaas@gmail.com, andres@anarazel.de, craig@2ndquadrant.com, thomas.munro@enterprisedb.com, simon@2ndquadrant.com
  Subject: Re: Postgres, fsync, and OSs (specifically linux)
  In-Reply-To: <20180519010121.GV27724@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox