From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Date: Wed, 18 Jul 2018 15:55:24 +0900
Message-ID: <20180718065524.GE8565@paquier.xyz> (raw)
In-Reply-To: <CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
References: <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
<20180718062202.GC8565@paquier.xyz>
<CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
On Wed, Jul 18, 2018 at 12:15:25PM +0530, Ashutosh Bapat wrote:
> On Wed, Jul 18, 2018 at 11:52 AM, Michael Paquier <michael@paquier.xyz> wrote:
>> On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
>>> Hi,
>>>
>>> While debugging planner I realized that print_path() function is not
>>> aware of both GatherMerge path and CustomScan path. Attached small
>>> patch fixes it.
>>
>> Good catch. Those should be backpatched. While I am looking at this
>> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
>> T_MergeAppend and not T_MergeAppendPath.
>>
>> This is new as of f49842d1 in v11.
>
> Yes that's right. Thanks for taking care of it.
Thanks for the confirmation. Robert, do you want to take care of this
issue or should I?
>> Robert, Ashutosh, am I missing
>> something?
>
> You used my personal email id by mistake, I think. I have removed it
> and added by EDB email address.
My sincere apologies. I have not been careful.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, ashutosh.bapat@enterprisedb.com, sawada.mshk@gmail.com, robertmhaas@gmail.com
Subject: Re: print_path is missing GatherMerge and CustomScan support
In-Reply-To: <20180718065524.GE8565@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox