From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Date: Thu, 19 Jul 2018 15:26:50 +0900
Message-ID: <20180719062650.GL3411@paquier.xyz> (raw)
In-Reply-To: <CAFjFpRf3yGODbCyrR4zfcbWbQOv=DqtfvwZ=qUh2Wfa3ODe-TA@mail.gmail.com>
References: <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
<20180718062202.GC8565@paquier.xyz>
<CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
<20180719000722.GA3411@paquier.xyz>
<CAFjFpRf3yGODbCyrR4zfcbWbQOv=DqtfvwZ=qUh2Wfa3ODe-TA@mail.gmail.com>
On Thu, Jul 19, 2018 at 10:41:10AM +0530, Ashutosh Bapat wrote:
> I had extensive testcases in my original patch-set to exercise that
> code but 1. that testset was too extensive; even today
> partition_join.sql is a separate testcase and it's quite large. 2.
> that function returns NULL rather than throwing an error, if it can
> not produce a parameterized path. So, unless we check whether each of
> those paths get created no test is useful and that can only be done
> through an EXPLAIN OUTPUT which means that the testcase becomes
> fragile. I fine if we want to add more tests just to cover the code if
> those are not as fragile and do not blow up partition_join too much.
Did those really check the reparameterization of a MergeAppendPath for a
child of the parent? I'd be surprised if this one was stressed as there
was no match in the list.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, ashutosh.bapat@enterprisedb.com, sawada.mshk@gmail.com, robertmhaas@gmail.com
Subject: Re: print_path is missing GatherMerge and CustomScan support
In-Reply-To: <20180719062650.GL3411@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox