pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: C99 compliance for src/port/snprintf.c
Date: Wed, 15 Aug 2018 12:56:43 -0300
Message-ID: <20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com>

On 2018-Aug-15, Robert Haas wrote:

> On Tue, Aug 14, 2018 at 7:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I'm almost tempted to think that the reasons above make this a
> > back-patchable bug fix.  Comments?
> 
> No objections to changing the behavior.  Have you checked whether
> there are any noticeable performance consequences?
> 
> Back-patching seems a bit aggressive to me considering that the danger
> is hypothetical.

That was my first thought too, and my preferred path would be to make
this master-only and only consider a backpatch later if we find some
practical reason to do so.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (46+ messages)  latest in thread

Message-ID: <20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql>
Permalink:  ../20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql/
Also on:    postgresql.org/message-id/20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: C99 compliance for src/port/snprintf.c
  In-Reply-To: <20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox