pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Date: Fri, 31 Aug 2018 17:33:03 -0700
Message-ID: <20180901003303.GE5305@paquier.xyz> (raw)
In-Reply-To: <15258.1535759998@sss.pgh.pa.us>
References: <1535618100.1286.3.camel@credativ.de>
	<alpine.DEB.2.21.1808301325070.32764@lancre>
	<7321.1535639966@sss.pgh.pa.us>
	<20180830175652.GC15446@paquier.xyz>
	<12123.1535672257@sss.pgh.pa.us>
	<20180831000600.GI15446@paquier.xyz>
	<28226.1535727306@sss.pgh.pa.us>
	<21037.1535745351@sss.pgh.pa.us>
	<20180831222119.GD5305@paquier.xyz>
	<15258.1535759998@sss.pgh.pa.us>

On Fri, Aug 31, 2018 at 07:59:58PM -0400, Tom Lane wrote:
> The others you mention could be changed, probably, but I didn't
> bother as they didn't seem performance-critical.

It is not really critical indeed.  There is an argument to change them
so as other folks get used to it though.

> (I also wondered whether to use "WAL" instead of "XLog" in that
> struct name, but it seems like we've mostly stuck with "xlog"
> in internal C names.)

XLOG_BLCKSZ is used, which makes me think that XLog is better than WAL
here.  A matter of taste of course.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (34+ messages)  latest in thread

Message-ID: <20180901003303.GE5305@paquier.xyz>
Permalink:  ../20180901003303.GE5305@paquier.xyz/
Also on:    postgresql.org/message-id/20180901003303.GE5305@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, michael.banck@credativ.de
  Subject: Re: pg_verify_checksums and -fno-strict-aliasing
  In-Reply-To: <20180901003303.GE5305@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox