From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Date: Sat, 1 Sep 2018 16:19:00 -0700
Message-ID: <20180901231900.GF5305@paquier.xyz> (raw)
In-Reply-To: <12600.1535830330@sss.pgh.pa.us>
References: <7321.1535639966@sss.pgh.pa.us>
<20180830175652.GC15446@paquier.xyz>
<12123.1535672257@sss.pgh.pa.us>
<20180831000600.GI15446@paquier.xyz>
<28226.1535727306@sss.pgh.pa.us>
<21037.1535745351@sss.pgh.pa.us>
<20180831222119.GD5305@paquier.xyz>
<15258.1535759998@sss.pgh.pa.us>
<20180901003303.GE5305@paquier.xyz>
<12600.1535830330@sss.pgh.pa.us>
On Sat, Sep 01, 2018 at 03:32:10PM -0400, Tom Lane wrote:
> Fair enough. I renamed the types as suggested, changed a few more
> places for consistency's sake, and pushed.
Thanks!
> There still remain some places where palloc(BLCKSZ) or equivalent is used,
> but there's no matching pfree. In a lot of them the buffer is returned
> to the caller so there's no choice. It's likely that some are just
> leaking the storage transiently and we could convert them to using a
> PGAlignedBlock local variable, but I didn't bother trying to do the
> analysis.
At quick glance, I am not seeing anything critical. So the result looks
good to me.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, michael.banck@credativ.de
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
In-Reply-To: <20180901231900.GF5305@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox