pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE
Date: Mon, 3 Sep 2018 14:29:09 +0300
Message-ID: <20180903112908.GA2509@zakirov.localdomain> (raw)
In-Reply-To: <d8jk1o7vlq8.fsf@dalvik.ping.uio.no>
References: <d8jo9djvm7h.fsf@dalvik.ping.uio.no>
	<d8jk1o7vlq8.fsf@dalvik.ping.uio.no>

Hello,

On Thu, Aug 30, 2018 at 05:54:23PM +0100, Dagfinn Ilmari Mannsåker wrote:
> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> > Hi hackers,
> >
> > I just noticed that psql's tab completion for ALTER TABLE … SET
> > TABLESPACE was treating it as any other configuration parameter and
> > completing with FROM DEFAULT or TO after it, instead of a list of
> > tablespaces.
> 
> And just after hitting send, I noticed I'd typed ALTER TABLE instead of
> ALTER DATABASE, including in the commit message :(
> 
> Fixed patch attached.

+1. Attached patch works nicely. It applies using "patch".

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company




view thread (22+ messages)  latest in thread

Message-ID: <20180903112908.GA2509@zakirov.localdomain>
Permalink:  ../20180903112908.GA2509@zakirov.localdomain/
Also on:    postgresql.org/message-id/20180903112908.GA2509@zakirov.localdomain

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.zakirov@postgrespro.ru, ilmari@ilmari.org
  Subject: Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE
  In-Reply-To: <20180903112908.GA2509@zakirov.localdomain>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox