From: Noah Misch <noah@leadboat.com>
To: tgl@sss.pgh.pa.us, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: robertmhaas@gmail.com
Cc: andres@2ndquadrant.com
Cc: andrew@dunslane.net
Cc: pgsql-hackers@postgresql.org
Subject: Re: Something fishy happening on frogmouth
Date: Sun, 23 Sep 2018 23:32:41 -0700
Message-ID: <20180924063241.GA3873667@rfd.leadboat.com> (raw)
In-Reply-To: <20180919.130344.143733188.horiguchi.kyotaro@lab.ntt.co.jp>
References: <CA+Tgmoa477p+T6n5Sh_qRSvzj8TPYoJgve0tmAGt5cpLta8FSA@mail.gmail.com>
<20180915221546.GA3159382@rfd.leadboat.com>
<15555.1537050112@sss.pgh.pa.us>
<20180919.130344.143733188.horiguchi.kyotaro@lab.ntt.co.jp>
On Wed, Sep 19, 2018 at 01:03:44PM +0900, Kyotaro HORIGUCHI wrote:
> Thank you for finding and fixing this.
>
> At Sat, 15 Sep 2018 18:21:52 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in <15555.1537050112@sss.pgh.pa.us>
> > Noah Misch <noah@leadboat.com> writes:
> > > Usually, the first srandom() call happens early in PostmasterMain(). I plan
> > > to add one to InitStandaloneProcess(), which substitutes for several tasks
> > > otherwise done in PostmasterMain(). That seems like a good thing even if DSM
> > > weren't in the picture. Also, initdb needs an srandom() somewhere;
> > > choose_dsm_implementation() itself seems fine. Attached.
> >
> > +1, but some comments would be good.
> +1, too.
Thanks for reviewing. I pushed with some comments.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, horiguchi.kyotaro@lab.ntt.co.jp, robertmhaas@gmail.com, andres@2ndquadrant.com, andrew@dunslane.net
Subject: Re: Something fishy happening on frogmouth
In-Reply-To: <20180924063241.GA3873667@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox