pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: hlinnaka <hlinnaka@iki.fi>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Problem while setting the fpw with SIGHUP
Date: Thu, 27 Sep 2018 21:51:55 +0900
Message-ID: <20180927125155.GA1745@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1KcZYFzTDy1CX2UdPMy1EzeOA3_MSGXhW1bqE3ZTo0=PA@mail.gmail.com>
References: <20180906233728.GR2726@paquier.xyz>
	<20180914072655.GI29332@paquier.xyz>
	<CAA4eK1+Xfx5jD2CHmLPNqXeOzqRLKG9TNr8wfs3-cPf9Ln9RVg@mail.gmail.com>
	<20180918.161542.79085818.horiguchi.kyotaro@lab.ntt.co.jp>
	<20180919052034.GI1650@paquier.xyz>
	<CAA4eK1JVUmrA4rZDScR7npovm0TfJqq5AQKAdQVRCQ4+_JZCJQ@mail.gmail.com>
	<20180927050440.GR1659@paquier.xyz>
	<CAA4eK1Kbjjwq3BCfVuNcr7oph4b0kvf7YyEwTF+6v_KytrBgaA@mail.gmail.com>
	<20180927080221.GU1659@paquier.xyz>
	<CAA4eK1KcZYFzTDy1CX2UdPMy1EzeOA3_MSGXhW1bqE3ZTo0=PA@mail.gmail.com>

On Thu, Sep 27, 2018 at 04:19:02PM +0530, Amit Kapila wrote:
> I think this is mostly fine, but it seems "if the instance just got
> out of recovery" doesn't fit well because it can happen anytime after
> recovery, this code gets called from checkpointer.  I think we can
> slightly tweak it as below:
> "Perform this outside critical section so that the WAL insert
> initialization done by RecoveryInProgress() doesn't trigger an
> assertion failure."
> 
> What do you say?

Fine for me.

>> Sure, feel free to if you have some room.  I am fine to take care of it
>> as well, so that's up to you to decide.
> 
> Okay, I will take care of it.

Thanks.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20180927125155.GA1745@paquier.xyz/2-signature.asc)
  download

view thread (75+ messages)  latest in thread

Message-ID: <20180927125155.GA1745@paquier.xyz>
Permalink:  ../20180927125155.GA1745@paquier.xyz/
Also on:    postgresql.org/message-id/20180927125155.GA1745@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, amit.kapila16@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, robertmhaas@gmail.com, hlinnaka@iki.fi, dilipbalaut@gmail.com
  Subject: Re: Problem while setting the fpw with SIGHUP
  In-Reply-To: <20180927125155.GA1745@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox