From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Surafel Temesgen <surafel3000@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump multi VALUES INSERT
Date: Wed, 17 Oct 2018 15:05:28 -0400
Message-ID: <20181017190528.GD4184@tamriel.snowman.net> (raw)
In-Reply-To: <27171.1539719339@sss.pgh.pa.us>
References: <CALAY4q9kumSdnRBzvRJvSRf2+BH20YmSvzqOkvwpEmodD-xv6g@mail.gmail.com>
<27171.1539719339@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Surafel Temesgen <surafel3000@gmail.com> writes:
> > According to the documentation –inserts option is mainly useful for making
> > dumps that can be loaded into non-PostgreSQL databases and to reduce the
> > amount of rows that might lost during error in reloading but multi values
> > insert command are equally portable and compact and also faster to reload
> > than single row statement. I think it deserve an option of its own
>
> I don't actually see the point of this. If you want dump/reload speed
> you should be using COPY. If that isn't your first priority, it's
> unlikely that using an option like this would be a good idea. It makes
> the effects of a bad row much harder to predict, and it increases your
> odds of OOM problems with wide rows substantially.
>
> I grant that COPY might not be an option if you're trying to transfer
> data to a different DBMS, but the other problems seem likely to apply
> anywhere. The bad-data hazard, in particular, is probably a much larger
> concern than it is for Postgres-to-Postgres transfers.
I can't say that I can really buy off on this argument.
The point of it is that it makes loading into other RDBMS faster. Yes,
it has many of the same issues as our COPY does, but we support it
because it's much faster. The same is true here, just for other
databases, so I'm +1 on the general idea.
I've not looked at the patch itself at all, yet.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, surafel3000@gmail.com
Subject: Re: pg_dump multi VALUES INSERT
In-Reply-To: <20181017190528.GD4184@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox