pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [RFC] Removing "magic" oids
Date: Sat, 27 Oct 2018 11:56:56 -0700
Message-ID: <20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de> (raw)
In-Reply-To: <CAA4eK1KPp2O54pQdvSUiG1NHoWPhA+jYTNWvN8637_=ME7hoJg@mail.gmail.com>
References: <20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de>
	<CAA4eK1KPp2O54pQdvSUiG1NHoWPhA+jYTNWvN8637_=ME7hoJg@mail.gmail.com>

Hi,

On 2018-10-28 00:21:23 +0530, Amit Kapila wrote:
> On Sun, Sep 30, 2018 at 9:18 AM Andres Freund <andres@anarazel.de> wrote:
> > I think we should drop WITH OIDs support.  pg_dump should convert WITH
> > OIDs tables into tables that have an explicit oid column (with an
> > appropriate default function), pg_upgrade should refuse to upgrade them.
> >
> 
> Is there any technical reason why you think pg_upgrade should refuse
> to upgrade them?  I think there is an argument to break backward
> compatibility here and many people on the thread seem to be okay with
> that, but refusing to upgrade sounds more restrictive.

They'd not be on-disk compatible, because the column isn't stored as a
normal column but in the t_hoff space.

Greetings,

Andres Freund




view thread (48+ messages)  latest in thread

Message-ID: <20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de>
Permalink:  ../20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, amit.kapila16@gmail.com
  Subject: Re: [RFC] Removing "magic" oids
  In-Reply-To: <20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox