From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT
Date: Fri, 2 Nov 2018 10:51:52 +0900
Message-ID: <20181102015152.GU1727@paquier.xyz> (raw)
In-Reply-To: <20181101040443.GF1727@paquier.xyz>
References: <CAKcux6mhgcjSiB_egqEAEFgX462QZtncU8QCAJ2HZwM-wWGVew@mail.gmail.com>
<2bf804fb-7417-4539-51c5-f6419f1e8741@lab.ntt.co.jp>
<7193.1536768840@sss.pgh.pa.us>
<e1b7c3ec-dbfc-4295-8bec-ee985114ecb5@lab.ntt.co.jp>
<10741.1536848021@sss.pgh.pa.us>
<1d3837d8-1722-54bb-9df3-19ae5158dc88@lab.ntt.co.jp>
<06f61571-56fb-f4a5-6bc5-dc11c1f05a5a@lab.ntt.co.jp>
<20181101040443.GF1727@paquier.xyz>
On Thu, Nov 01, 2018 at 01:04:43PM +0900, Michael Paquier wrote:
> On Thu, Nov 01, 2018 at 12:39:16PM +0900, Amit Langote wrote:
>> Rajkumar pointed out off-list that the patch still remains to be applied.
>> Considering that there is a planned point release on Nov 8, maybe we
>> should do something about this?
>
> Yes doing something about that very soon would be a good idea. Tom,
> are you planning to look at it or should I jump in?
And so I am looking at v3 now...
Adding a test case in temp.sql would be nice.
Would it make sense to support TRUNCATE on a materialized as well in the
future? It seems to me that it is dangerous to assume that only
relations make use of heap_truncate_one_rel() anyway as modules or
external code could perfectly call it. And the thing is documented
to work on a relation, including materialized views, not just an
ordinary table which is what RELKIND_RELATION only mentions. On the
contrary we know that heap_truncate() works only on temporary
relations. It is documented to do so and does so.
So it seems to me that Tom correctly mentioned to add the check in
heap_truncate, not heap_truncate_one_rel(), so v3 looks incorrect to
me.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, rajkumar.raghuwanshi@enterprisedb.com
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT
In-Reply-To: <20181102015152.GU1727@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox