From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Subject: Re: speeding up planning with partitions
Date: Wed, 7 Nov 2018 00:32:07 -0300
Message-ID: <20181107033207.cdisp33ryrgeidef@alvherre.pgsql> (raw)
In-Reply-To: <f06a398a-40a9-efb4-fab9-784400fecf13@lab.ntt.co.jp>
ISTM patch 0004 is impossible to review just because of size -- I
suppose the bulk of it is just code that moves from one file to another,
but that there are also code changes in it. Maybe it would be better to
split it so that one patch moves the code to the new files without
changing it, then another patch does the actual functional changes? If
git shows the first half as a rename, it's easier to be confident about
it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, imai.yoshikazu@jp.fujitsu.com, david.rowley@2ndquadrant.com
Subject: Re: speeding up planning with partitions
In-Reply-To: <20181107033207.cdisp33ryrgeidef@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox