From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: s.cherkashin@postgrespro.ru
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Psql patch to show access methods info
Date: Tue, 20 Nov 2018 10:42:41 -0300
Message-ID: <20181120134241.36tjfswliqimvncv@alvherre.pgsql> (raw)
In-Reply-To: <64178681578cd2f1013db32bb7c00ddd@postgrespro.ru>
On 2018-Nov-20, s.cherkashin@postgrespro.ru wrote:
> Ok, I fixed this.
Cool. I'm not sure this is a good idea: "c.relname::pg_catalog.regclass"
I would use c.oid::pg_catalog.regclass instead.
But before getting into those details, I think we should discuss the
user interface that this patch is offering:
\dip [am pattern]
lists index properties (according to doc patch)
* OK, but why do we need an AM pattern? ... reads regress output ...
oh, actually it's an index name pattern, not an AM pattern. Please fix docs.
\dicp [idx pattern] [column pattern]
list index column properties
* I think the column pattern part is pointless.
\dA{f,p,fo,fp,oc}
Please explain what these are.
I think this is two patches -- one being the \dip/\dicp part, the other
the \dA additions. Let's deal with them separately?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, s.cherkashin@postgrespro.ru, michael@paquier.xyz, n.gluhov@postgrespro.ru
Subject: Re: Psql patch to show access methods info
In-Reply-To: <20181120134241.36tjfswliqimvncv@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox