From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: allow online change primary_conninfo
Date: Mon, 26 Nov 2018 09:13:29 +0900
Message-ID: <20181126001329.GC1776@paquier.xyz> (raw)
In-Reply-To: <20181125214313.lydvmrraqjfrb3s2@alap3.anarazel.de>
References: <19513901543181143@sas1-19a94364928d.qloud-c.yandex.net>
<20181125214313.lydvmrraqjfrb3s2@alap3.anarazel.de>
On Sun, Nov 25, 2018 at 01:43:13PM -0800, Andres Freund wrote:
> On 2018-11-26 00:25:43 +0300, Sergei Kornilov wrote:
>> I think we have no futher reason to have a copy of conninfo and slot
>> name in WalRcvData, so i propose remove these fields from
>> pg_stat_get_wal_receiver() (and pg_stat_wal_receiver view). This data
>> can be accesible now via regular GUC commands.
>
> Is that wise? It seems possible that wal receivers run for a while with
> the old connection information, and without this information that seems
> hard to debug.
No, that's unwise. One of the reasons why conninfo is around is that we
know to which server a receiver is connected when specifying multiple
host and/or port targets in the configuration. Please see 9a895462 for
the details.
Removing the slot does not look like an improvement to me either,
following Andres' argument.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, sk@zsrv.org
Subject: Re: allow online change primary_conninfo
In-Reply-To: <20181126001329.GC1776@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox