From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Adrien Nayrat <adrien.nayrat@anayrat.info>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: vik.fearing@2ndquadrant.com, Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: New GUC to sample log queries
Date: Thu, 29 Nov 2018 18:48:50 -0300
Message-ID: <20181129214850.kiq6mvofsgplqjdr@alvherre.pgsql> (raw)
In-Reply-To: <c80bad2d-c865-5bf2-71b9-fa95127d34f9@anayrat.info>
Thanks! I pushed this with two changes -- one was to reword the docs a
bit more, and the other was to compute in_sample only if it's going to
be used (when exceeded is true). I hope this won't upset any compilers ...
I wonder if there's any sensible way to verify the behavior in an
automated fashion. Who know what marvels we'd discover about the
reliability/uniformity of random() across platforms.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, adrien.nayrat@anayrat.info, thomas.munro@enterprisedb.com, 9erthalion6@gmail.com, tomas.vondra@2ndquadrant.com, robertmhaas@gmail.com, michael@paquier.xyz, david.rowley@2ndquadrant.com
Subject: Re: New GUC to sample log queries
In-Reply-To: <20181129214850.kiq6mvofsgplqjdr@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox