From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Too-short timeouts in test code
Date: Sun, 9 Dec 2018 11:14:12 +0900
Message-ID: <20181209021412.GC1833@paquier.xyz> (raw)
In-Reply-To: <20181209001601.GC2973271@rfd.leadboat.com>
References: <20181209001601.GC2973271@rfd.leadboat.com>
On Sat, Dec 08, 2018 at 04:16:01PM -0800, Noah Misch wrote:
> The 180s timeout in poll_query_until has been trouble-free since 2a0f89c
> introduced it two years ago. I plan to raise the timeouts in question to
> 180s, as attached.
That's annoying, thanks for tracking those down.
> @@ -72,7 +72,7 @@ my $endpos = $node_master->safe_psql('postgres',
> print "waiting to replay $endpos\n";
>
> my $stdout_recv = $node_master->pg_recvlogical_upto(
> - 'postgres', 'test_slot', $endpos, 10,
> + 'postgres', 'test_slot', $endpos, 180,
> 'include-xids' => '0',
> 'skip-empty-xacts' => '1');
Instead of allowing callers of pg_recvlogical_upto() to define the
timeout they want, perhaps it would be better to hardcode the timeout
limit within the routine?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20181209021412.GC1833@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, noah@leadboat.com
Subject: Re: Too-short timeouts in test code
In-Reply-To: <20181209021412.GC1833@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox