From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Date: Sun, 9 Dec 2018 12:48:15 -0500
Message-ID: <20181209174815.GD3415@tamriel.snowman.net> (raw)
In-Reply-To: <20181208231507.GA1833@paquier.xyz>
References: <20181207010406.GO2407@paquier.xyz>
<20181207230540.GA12740@paquier.xyz>
<6105.1544243612@sss.pgh.pa.us>
<20181208065436.GC1989@paquier.xyz>
<20181208134608.GY3415@tamriel.snowman.net>
<20181208231507.GA1833@paquier.xyz>
Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Sat, Dec 08, 2018 at 08:46:08AM -0500, Stephen Frost wrote:
> > I wonder if we maybe should have a regression test for every such
> > function which just queries the catalog in a way to force the function
> > to be called for every relation defined in the regression tests, to
> > ensure that it doesn't segfault or throw an error..
>
> Like sqlsmith? It looks hard to me to make something like that part of
> the main regression test suite, as that's going to be costly and hard to
> scale with.
No, I mean something like:
with x as (select pg_partition_tree(relname) from pg_class)
select 1 from x limit 1;
or whatever it takes to make sure that the function is run against every
entry in pg_class (or whatever is appropriate) while not returning the
results (since we don't actually care about the output, we just want to
make sure it doesn't ERROR or crash).
sqlsmith, as I recall, doesn't care about ERROR cases, it's just looking
for crashes, so it's not quite the same thing.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20181209174815.GD3415@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, michael@paquier.xyz, tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: pg_partition_tree crashes for a non-defined relation
In-Reply-To: <20181209174815.GD3415@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox