From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <jcnaylor@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically assigning catalog toast oids
Date: Sun, 9 Dec 2018 15:42:57 -0500
Message-ID: <20181209204257.GH3415@tamriel.snowman.net> (raw)
In-Reply-To: <18075.1544380583@sss.pgh.pa.us>
References: <CAJVSVGWjRjY6Kg+sriZitkVVjjH8i4uEyVrQf1bwdu2z61=XLQ@mail.gmail.com>
<18075.1544380583@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> John Naylor <jcnaylor@gmail.com> writes:
> > Commit 96cdeae07 added toast tables to most catalogs. One disadvantage
> > is that the toast declarations require hard-coded oids, even though
> > only shared catalogs actually need stable oids. Now that we can assign
> > oids on the fly, it makes sense to do so for toast tables as well, as
> > in the attached.
>
> I'm a bit dubious that this is a good idea. It's handy, at least for
> forensic situations, that the system catalogs have stable OIDs.
I tend to agree... What's the advantage of assigning them on the fly?
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20181209204257.GH3415@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, jcnaylor@gmail.com
Subject: Re: automatically assigning catalog toast oids
In-Reply-To: <20181209204257.GH3415@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox