pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Christoph Berg <christoph.berg@credativ.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log PostgreSQL version number on startup
Date: Mon, 10 Dec 2018 15:33:07 +0900
Message-ID: <20181210063307.GD1105@paquier.xyz> (raw)
In-Reply-To: <20181121163246.GR3415@tamriel.snowman.net>
References: <20181121144611.GJ15795@msg.credativ.de>
	<20181121163246.GR3415@tamriel.snowman.net>

On Wed, Nov 21, 2018 at 11:32:46AM -0500, Stephen Frost wrote:
> * Christoph Berg (christoph.berg@credativ.de) wrote:
>> it has bugged me for a long time that there's no clear "PostgreSQL is
>> starting" message in the server log file. I'd like to change that for
>> two reasons:
> 
> +1

+1.  One complain which could be formulated is that this makes the
logs at startup more noisy.  Now your patch has an issue if you want to
ensure that this information gets added to the log files, because at
this stage of startup the GUCs are not loaded, hence this is sent to
stderr, and perhaps not on the log files.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20181210063307.GD1105@paquier.xyz/2-signature.asc)
  download

view thread (12+ messages)  latest in thread

Message-ID: <20181210063307.GD1105@paquier.xyz>
Permalink:  ../20181210063307.GD1105@paquier.xyz/
Also on:    postgresql.org/message-id/20181210063307.GD1105@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, sfrost@snowman.net, christoph.berg@credativ.de
  Subject: Re: [PATCH] Log PostgreSQL version number on startup
  In-Reply-To: <20181210063307.GD1105@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox