pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <christoph.berg@credativ.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log PostgreSQL version number on startup
Date: Mon, 10 Dec 2018 10:57:39 +0100
Message-ID: <20181210095739.GB13629@msg.credativ.de> (raw)
In-Reply-To: <20181210063307.GD1105@paquier.xyz>
References: <20181121144611.GJ15795@msg.credativ.de>
	<20181121163246.GR3415@tamriel.snowman.net>
	<20181210063307.GD1105@paquier.xyz>

Re: Michael Paquier 2018-12-10 <20181210063307.GD1105@paquier.xyz>
> On Wed, Nov 21, 2018 at 11:32:46AM -0500, Stephen Frost wrote:
> > * Christoph Berg (christoph.berg@credativ.de) wrote:
> >> it has bugged me for a long time that there's no clear "PostgreSQL is
> >> starting" message in the server log file. I'd like to change that for
> >> two reasons:
> > 
> > +1
> 
> +1.  One complain which could be formulated is that this makes the
> logs at startup more noisy.  Now your patch has an issue if you want to
> ensure that this information gets added to the log files, because at
> this stage of startup the GUCs are not loaded, hence this is sent to
> stderr, and perhaps not on the log files.

I placed it so that it gets logged after logging_collector is active.

Christoph
-- 
Senior Berater, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz




view thread (12+ messages)  latest in thread

Message-ID: <20181210095739.GB13629@msg.credativ.de>
Permalink:  ../20181210095739.GB13629@msg.credativ.de/
Also on:    postgresql.org/message-id/20181210095739.GB13629@msg.credativ.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: christoph.berg@credativ.de, michael@paquier.xyz, sfrost@snowman.net
  Subject: Re: [PATCH] Log PostgreSQL version number on startup
  In-Reply-To: <20181210095739.GB13629@msg.credativ.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox