From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Noah Misch <noah@leadboat.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Mon, 10 Dec 2018 13:20:03 -0500
Message-ID: <20181210182003.GM3415@tamriel.snowman.net> (raw)
In-Reply-To: <20181208001735.GT3415@tamriel.snowman.net>
References: <696c2d04-80aa-57e2-c1c5-6df25e2bbed5@lab.ntt.co.jp>
<20170503030520.GR21223@tamriel.snowman.net>
<CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com>
<20170504214702.GP21223@tamriel.snowman.net>
<20170506031749.GD843225@rfd.leadboat.com>
<CAOuzzgpmP8uDmqh9ekwR2VUakm_9=B1X6vyyZK+xazwK+s1Hug@mail.gmail.com>
<3e2aa1e9-e621-9ad5-b24d-e24dbc9650ba@lab.ntt.co.jp>
<20170508034245.GY21223@tamriel.snowman.net>
<ff0b4014-28d0-7937-59c9-075aad27e976@lab.ntt.co.jp>
<20181208001735.GT3415@tamriel.snowman.net>
Greetings,
* Stephen Frost (sfrost@snowman.net) wrote:
> Greetings,
>
> * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> > On 2017/05/08 12:42, Stephen Frost wrote:
> > > * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> > >> Thanks for committing the patch after improving it quite a bit, and sorry
> > >> that I couldn't reply promptly during the last week due to vacation.
> > >
> > > No worries, hopefully you have an opportunity to review the additional
> > > changes I made and understand why they were necessary. Certainly, feel
> > > free to reach out if you have any questions or notice anything else
> > > which should be improved.
> >
> > Do you intend to push the other patch to add regression tests for the
> > non-inherited constraints? Here it is attached again for you to look over.
>
> In a blast from the past, I had a long-lost note about trying to push
> this that I just stumbled over.
>
> Apologies for it getting lost in the cracks. I've rebased it and will
> plan to push it later this weekend, barring objections.
This has now been pushed.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20181210182003.GM3415@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, Langote_Amit_f8@lab.ntt.co.jp, noah@leadboat.com, amitlangote09@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <20181210182003.GM3415@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox