From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: could recovery_target_timeline=latest be the default in standby mode?
Date: Fri, 28 Dec 2018 08:15:14 +0900
Message-ID: <20181227231514.GD2196@paquier.xyz> (raw)
In-Reply-To: <6759b48b-5623-b917-0bc8-c4402a3ca338@pgmasters.net>
References: <6dd2c23a-4162-8469-410f-bfe146e28c0c@2ndquadrant.com>
<7495701545389660@sas1-87f9feb8d943.qloud-c.yandex.net>
<20181221233819.GE1948@paquier.xyz>
<249bd41d-0385-3038-4394-a42f00e1a045@2ndquadrant.com>
<6759b48b-5623-b917-0bc8-c4402a3ca338@pgmasters.net>
On Thu, Dec 27, 2018 at 06:36:23PM +0200, David Steele wrote:
> I like the idea of defaulting to the latest timeline since this is what you
> want to do most of the time, but I think we'd then need a value for
> following the current timelime, i.e. the one that the backup was taken on
> (which is the current default).
>
> [...]
>
> I would recommend:
>
> 1) Make the default for recovery_target_timeline always be latest.
> 2) Add a new value, current, that replicates the current behavior.
Yes, I was also thinking something among those lines, and the patch is
a bit confusing by linking standby mode with latest timeline. It
seems to me that switching the default value to "latest" at GUC level
would be the way to go, instead of picking up the TLI from the control
file. Introducing a new value which maps to the current empty value
may be useful as well, like "control_file"?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, david@pgmasters.net, peter.eisentraut@2ndquadrant.com, sk@zsrv.org
Subject: Re: could recovery_target_timeline=latest be the default in standby mode?
In-Reply-To: <20181227231514.GD2196@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox