From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Date: Fri, 28 Dec 2018 10:30:27 +0900
Message-ID: <20181228013027.GD3210@paquier.xyz> (raw)
In-Reply-To: <bd6b833b-8250-0810-dfb6-4d8b3e6581b0@2ndquadrant.com>
References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de>
<20181221232834.GB1948@paquier.xyz>
<CABUevEyUaB=Ws=DW-XsBw4ibDXZhQZ8d3WR4485bkmm13kTGVw@mail.gmail.com>
<348aef85-a967-80d2-7bef-7274909475cf@2ndquadrant.com>
<20181227232529.GA3210@paquier.xyz>
<bd6b833b-8250-0810-dfb6-4d8b3e6581b0@2ndquadrant.com>
On Fri, Dec 28, 2018 at 01:14:05AM +0100, Tomas Vondra wrote:
> I'm sorry, but I'm not sure I understand the question. Of course, asking
> over at -packagers won't hurt, but my guess is the response will be it's
> not a big deal from the packaging perspective.
(The previous email had an extra "Would"... Sorry.)
Let's ask those folks then.
> What do you mean by "control" here? Dealing with checksum failures, or
> some additional capabilities?
What I am referring to here is the possibility to enable, disable and
check checksums for an online cluster. I am not sure what kind of
tooling able to do chirurgy at page level would make sense. Once a
checksum is corrupted a user knows about a problem, which mainly needs
a human lookup.
> I'm not sure data checksums are particularly great evidence. For example
> with the recent fsync issues, we might have ended with partial writes
> (and thus invalid checksums). The OS migh have even told us about the
> failure, but we've gracefully ignored it. So I'm afraid data checksums
> are not a particularly great proof it's not our fault.
Sure, they are not a solution to all problems. Still they give hints
before the problem spreads, and sometimes by looking at one corrupted
page by yourself one can see if the data fetched from disk comes from
Postgres or not (say inspecting the page header with pageinspect,
etc.).
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20181228013027.GD3210@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tomas.vondra@2ndquadrant.com, magnus@hagander.net, michael.banck@credativ.de
Subject: Re: Offline enabling/disabling of data checksums
In-Reply-To: <20181228013027.GD3210@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox