From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Minor comment fix for pg_config_manual.h
Date: Fri, 28 Dec 2018 00:37:41 -0300
Message-ID: <201812280337.4a5kfhhzeje3@alvherre.pgsql> (raw)
In-Reply-To: <20181228014143.GE3210@paquier.xyz>
On 2018-Dec-28, Michael Paquier wrote:
> On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote:
> > like the attached perhaps? At the same time I am thinking about
> > reformulating the second sentence as well..
> >
> > /*
> > - * This is default value for wal_segment_size to be used at initdb when run
> > - * without --walsegsize option. Must be a valid segment size.
> > + * This is the default value for wal_segment_size to be used when initdb is run
> > + * without the --wal-segsize option. It must be a valid segment size.
> > */
> > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024)
>
> So, any objections with this change? If somebody has a better
> wording, please feel free to chime in.
Looks good to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, ian.barwick@2ndquadrant.com
Subject: Re: Minor comment fix for pg_config_manual.h
In-Reply-To: <201812280337.4a5kfhhzeje3@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox