From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Move regression.diffs of pg_upgrade test suite
Date: Sun, 30 Dec 2018 11:28:56 -0500
Message-ID: <20181230162856.GA187973@gust.leadboat.com> (raw)
In-Reply-To: <37ead3b7-b4a9-5a1f-6a10-c6ab9eb0d2aa@2ndQuadrant.com>
References: <20181224034411.GA3224776@rfd.leadboat.com>
<ede9f7a3-2082-ce59-abb0-fe867dc03bbb@2ndQuadrant.com>
<22708.1545861757@sss.pgh.pa.us>
<20181226224428.GA3277716@rfd.leadboat.com>
<37ead3b7-b4a9-5a1f-6a10-c6ab9eb0d2aa@2ndQuadrant.com>
On Sun, Dec 30, 2018 at 10:41:46AM -0500, Andrew Dunstan wrote:
> On 12/26/18 5:44 PM, Noah Misch wrote:
> > On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote:
> >> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> >>> On 12/23/18 10:44 PM, Noah Misch wrote:
> >>>> A disadvantage of any change here is that it degrades buildfarm reports, which
> >>>> recover slowly as owners upgrade to a fixed buildfarm release. This will be
> >>>> similar to the introduction of --outputdir=output_iso. On non-upgraded
> >>>> animals, pg_upgradeCheck failures will omit regression.diffs.
> >> Do we need to change anything in the buildfarm client to improve its
> >> response to this? If so, seems like it might be advisable to make a
> >> buildfarm release with the upgrade before committing the change.
> >> Sure, not all owners will update right away, but if they don't even
> >> have the option then we're not in a good place.
> >
> > It would have been convenient if, for each test target, PostgreSQL code
> > decides the list of interesting log files and presents that list for the
> > buildfarm client to consume. It's probably overkill to redesign that now,
> > though. I also don't think it's of top importance to have unbroken access to
> > this regression.diffs, because defects that cause this run to fail will
> > eventually upset "install-check-C" and/or "check". Even so, it's fine to
> > patch the buildfarm client in advance of the postgresql.git change:
> >
> > diff --git a/PGBuild/Modules/TestUpgrade.pm b/PGBuild/Modules/TestUpgrade.pm
> I'll commit this or something similar, but I generally try not to make
> new releases more frequently than once every 3 months, and it's only six
> weeks since the last release. So unless there's a very good reason I am
> not planning on a release before February.
There's no rush; I don't recall other reports of the spurious failure
described in the original post. I'll plan to push the postgresql.git change
around 2019-03-31, so animals updating within a month of release will have no
degraded pg_upgradeCheck failure reports.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: Move regression.diffs of pg_upgrade test suite
In-Reply-To: <20181230162856.GA187973@gust.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox