From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Move regression.diffs of pg_upgrade test suite
Date: Wed, 26 Dec 2018 17:02:37 -0500
Message-ID: <22708.1545861757@sss.pgh.pa.us> (raw)
In-Reply-To: <ede9f7a3-2082-ce59-abb0-fe867dc03bbb@2ndQuadrant.com>
References: <20181224034411.GA3224776@rfd.leadboat.com>
<ede9f7a3-2082-ce59-abb0-fe867dc03bbb@2ndQuadrant.com>
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 12/23/18 10:44 PM, Noah Misch wrote:
>> A disadvantage of any change here is that it degrades buildfarm reports, which
>> recover slowly as owners upgrade to a fixed buildfarm release. This will be
>> similar to the introduction of --outputdir=output_iso. On non-upgraded
>> animals, pg_upgradeCheck failures will omit regression.diffs.
>>
>> I think the right fix, attached, is to use "pg_regress --outputdir" to
>> redirect these files to src/bin/pg_upgrade/tmp_check/regress.
> Seems reasonable.
Do we need to change anything in the buildfarm client to improve its
response to this? If so, seems like it might be advisable to make a
buildfarm release with the upgrade before committing the change.
Sure, not all owners will update right away, but if they don't even
have the option then we're not in a good place.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, noah@leadboat.com
Subject: Re: Move regression.diffs of pg_upgrade test suite
In-Reply-To: <22708.1545861757@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox