agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: ah@cybertec.at
Cc: magnus@hagander.net
Cc: robertmhaas@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Date: Tue, 1 Jan 2019 20:42:26 -0300
Message-ID: <201901012342.rc2qe2a7ymyw@alvherre.pgsql> (raw)
In-Reply-To: <54232a9d-0bba-2bc2-6ed2-70598372459c@2ndquadrant.com>
On 2019-Jan-01, Tomas Vondra wrote:
> I agree it's a sensitive part of the code, so additional reviews would
> be welcome of course. I've done as much review and testing as possible,
> and overall it seems in a fairly good shape. Do you have any particular
> concerns / ideas what to look for?
I haven't reviewed this patch thoroughly.
Shall we do a triage run over the complete commitfest to determine the
highest priority items that we should put extra effort into reviewing?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
view thread (238+ messages) latest in thread
Message-ID: <201901012342.rc2qe2a7ymyw@alvherre.pgsql>
Permalink: ../201901012342.rc2qe2a7ymyw@alvherre.pgsql/
Also on: postgresql.org/message-id/201901012342.rc2qe2a7ymyw@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tomas.vondra@2ndquadrant.com, andres@anarazel.de, horiguchi.kyotaro@lab.ntt.co.jp, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: shared-memory based stats collector
In-Reply-To: <201901012342.rc2qe2a7ymyw@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox