pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: could recovery_target_timeline=latest be the default in standby mode?
Date: Sat, 12 Jan 2019 08:53:12 +0900
Message-ID: <20190111235312.GA26022@paquier.xyz> (raw)
In-Reply-To: <3b5bf434-9e29-4f19-914e-219d0af92422@2ndquadrant.com>
References: <6dd2c23a-4162-8469-410f-bfe146e28c0c@2ndquadrant.com>
	<7495701545389660@sas1-87f9feb8d943.qloud-c.yandex.net>
	<20181221233819.GE1948@paquier.xyz>
	<249bd41d-0385-3038-4394-a42f00e1a045@2ndquadrant.com>
	<6759b48b-5623-b917-0bc8-c4402a3ca338@pgmasters.net>
	<20181227231514.GD2196@paquier.xyz>
	<dbebe59f-fc22-9b4c-a6f8-4ed5816a70ea@2ndquadrant.com>
	<1c55a6a2-f7fa-4a4a-f90b-60fc5315d781@pgmasters.net>
	<20190108033750.GJ22498@paquier.xyz>
	<3b5bf434-9e29-4f19-914e-219d0af92422@2ndquadrant.com>

On Fri, Jan 11, 2019 at 11:17:48AM +0100, Peter Eisentraut wrote:
> Attached revised 0002 with those changes.

This one looks fine.

> In that test, if I change the 'current' to 'latest', the test doesn't
> fail, so it's probably not a good test.

I can see your point.  You would need a diverging timeline to test for
'latest', which can surely be done as part of 003_recovery_targets.pl.
It seems to me that that the test has initial value to make sure that
we replay up to the end of the produced timeline's data, which is
something untested now as the script has only restart points set to
before the end of the timeline.  If you think that's not a good
addition now, I am also fine to not include it.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (14+ messages)  latest in thread

Message-ID: <20190111235312.GA26022@paquier.xyz>
Permalink:  ../20190111235312.GA26022@paquier.xyz/
Also on:    postgresql.org/message-id/20190111235312.GA26022@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, david@pgmasters.net, sk@zsrv.org
  Subject: Re: could recovery_target_timeline=latest be the default in standby mode?
  In-Reply-To: <20190111235312.GA26022@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox