From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org, Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: unique, partitioned index fails to distinguish index key from INCLUDEd columns
Date: Mon, 14 Jan 2019 20:30:22 -0600
Message-ID: <20190115023022.GJ15177@telsasoft.com> (raw)
In-Reply-To: <201901142231.tbnjmhllnptv@alvherre.pgsql>
References: <20190109065109.GA4285@telsasoft.com>
<201901142231.tbnjmhllnptv@alvherre.pgsql>
On Mon, Jan 14, 2019 at 07:31:07PM -0300, Alvaro Herrera wrote:
> On 2019-Jan-09, Justin Pryzby wrote:
>
> > -- Fails to error
> > postgres=# CREATE UNIQUE INDEX ON t(j) INCLUDE(i);
> >
> > -- Fail to enforce uniqueness across partitions due to failure to enforce inclusion of partition key in index KEY
> > postgres=# INSERT INTO t VALUES(1,1);
> > postgres=# INSERT INTO t VALUES(2,1);
>
> Doh. Fix pushed. Commit 8224de4f42cc should have changed one
> appearance of ii_NumIndexAttrs to ii_NumIndexKeyAttrs, but because of
> the nature of concurrent development, nobody noticed.
I figured as much - I thought to test this while trying to fall asleep,
without knowing they were developed in parallel.
Should backpatch to v11 ?
0ad41cf537ea5f076273fcffa4c83a184bd9910f
Thanks,
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@2ndquadrant.com, teodor@sigaev.ru
Subject: Re: unique, partitioned index fails to distinguish index key from INCLUDEd columns
In-Reply-To: <20190115023022.GJ15177@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox