From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: unique, partitioned index fails to distinguish index key from INCLUDEd columns
Date: Tue, 15 Jan 2019 01:21:24 -0300
Message-ID: <201901150421.mlogf4cts5tj@alvherre.pgsql> (raw)
In-Reply-To: <20190115023022.GJ15177@telsasoft.com>
On 2019-Jan-14, Justin Pryzby wrote:
> On Mon, Jan 14, 2019 at 07:31:07PM -0300, Alvaro Herrera wrote:
> > Doh. Fix pushed. Commit 8224de4f42cc should have changed one
> > appearance of ii_NumIndexAttrs to ii_NumIndexKeyAttrs, but because of
> > the nature of concurrent development, nobody noticed.
>
> I figured as much - I thought to test this while trying to fall asleep,
> without knowing they were developed in parallel.
:-)
> Should backpatch to v11 ?
> 0ad41cf537ea5f076273fcffa4c83a184bd9910f
Yep, already done (src/tools/git_changelog in master):
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Branch: master [0ad41cf53] 2019-01-14 19:28:10 -0300
Branch: REL_11_STABLE [74aa7e046] 2019-01-14 19:25:19 -0300
Fix unique INCLUDE indexes on partitioned tables
We were considering the INCLUDE columns as part of the key, allowing
unicity-violating rows to be inserted in different partitions.
Concurrent development conflict in eb7ed3f30634 and 8224de4f42cc.
Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20190109065109.GA4285@telsasoft.com
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pryzby@telsasoft.com, teodor@sigaev.ru
Subject: Re: unique, partitioned index fails to distinguish index key from INCLUDEd columns
In-Reply-To: <201901150421.mlogf4cts5tj@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox