From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Fri, 18 Jan 2019 16:27:38 -0300
Message-ID: <201901181927.sbv5o72uu4cc@alvherre.pgsql> (raw)
In-Reply-To: <CAM6_UM7dm3LyExoVF2me2dCijd-e3o0oWEg3jKDrmg-b5x3Z4A@mail.gmail.com>
On 2019-Jan-18, Raúl Marín Rodríguez wrote:
> Hi,
>
> > Fun. But is that really the only place that fails?
>
> Yes, other than this it builds flawlessly.
>
> > This does not look right to me: glob has a different set of special
> > characters than regexes, no?
>
> The issue itself manifests in the grep call, not in glob, but I tried
> using `quotemeta` only for grep without success (probably because I didn't
> know how to properly call `quotemeta` over @logs.
Perhaps you can do
@quoted = map { quotemeta($_) } @logs;
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, rmrodriguez@carto.com, tgl@sss.pgh.pa.us
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
In-Reply-To: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox