From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
Date: Sat, 19 Jan 2019 16:54:59 +0900
Message-ID: <20190119075459.GF3306@paquier.xyz> (raw)
In-Reply-To: <20190117051101.GD2036@paquier.xyz>
References: <20180201062158.GD6398@paquier.xyz>
<60052986-956b-4478-45ed-8bd119e9b9cf@2ndquadrant.com>
<10797471544200851@myt3-964eae3a5b05.qloud-c.yandex.net>
<93a3d2fb-43a0-cf14-e8d0-d2c3195c1e5b@2ndquadrant.com>
<20486991544381729@iva5-d3020dc3459d.qloud-c.yandex.net>
<f57aa1f7-cc66-7fdb-27a8-7eedbd1467c7@2ndquadrant.com>
<36712441546604286@sas1-890ba5c2334a.qloud-c.yandex.net>
<20190116082705.GB2550@paquier.xyz>
<c11e1832-3c3e-c8a2-cdf4-3abc7b7ffdde@proxel.se>
<20190117051101.GD2036@paquier.xyz>
On Thu, Jan 17, 2019 at 02:11:01PM +0900, Michael Paquier wrote:
> Okay, I have begun digging into the patch, and extracted for now two
> things which can be refactored first, giving a total of three patches:
> - 0001, which creates WaitForOlderSnapshots to snapmgr.c. I think
> that this can be useful for external extensions to have a process wait
> for snapshots older than a minimum threshold hold by other
> transactions.
> - 0002, which moves the concurrent index build into its own routine,
> index_build_concurrent(). At the same time, index_build() has a
> isprimary argument which is not used, so let's remove it. This
> simplifies a bit the refactoring as well.
> - 0003 is the core patch, realigned with the rest, fixing some typos I
> found on the way.
Are there any objections if I commit 0001? Introducing
WaitForOlderSnapshots() is quite independent from the rest, and the
refactoring is obvious. For 0002, I am still not 100% sure if
index_build_concurrent() is the best interface but I am planning to
look more at this stuff next week, particularly the drop portion which
needs more work.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190119075459.GF3306@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andreas@proxel.se, sk@zsrv.org, peter.eisentraut@2ndquadrant.com, michael.paquier@gmail.com, sfrost@snowman.net, craig@2ndquadrant.com, alvherre@alvh.no-ip.org
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
In-Reply-To: <20190119075459.GF3306@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox