pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: A few new options for vacuumdb
Date: Sun, 27 Jan 2019 22:33:01 +0900
Message-ID: <20190127133301.GA15401@paquier.xyz> (raw)
In-Reply-To: <26A57CB3-2847-495F-93CA-9358959CDAD4@amazon.com>
References: <FF67D651-A7AF-4E70-9401-805E3CFB4DC9@amazon.com>
	<20190109010637.GC21835@paquier.xyz>
	<CAD21AoAqsSoTFWjajz1yycwxDnLZSWfV7wT7mmMBqy2k-jkLUQ@mail.gmail.com>
	<20190109043316.GH21835@paquier.xyz>
	<CAD21AoCzekiuDaGN-JqtoLgaYqqxGQ6nTcNqN0bm1EkvmcUKPA@mail.gmail.com>
	<5C971918-E566-41AB-895A-C4793D56B041@amazon.com>
	<20190122060730.GD8719@paquier.xyz>
	<F716EB06-0CBE-4342-9CFA-23409319B52A@amazon.com>
	<20190123034111.GH3873@paquier.xyz>
	<26A57CB3-2847-495F-93CA-9358959CDAD4@amazon.com>

On Thu, Jan 24, 2019 at 12:49:28AM +0000, Bossart, Nathan wrote:
> Oh, wow.  Thanks for pointing this out.  I should have caught this.
> With 0002, we are basically just throwing out the column lists
> entirely as we obtain the qualified identifiers from the catalog
> query.  To fix this, I've added an optional CTE for tracking any
> provided column lists.  v5-0001 is your test patch for this case, and
> v5-0002 splits out the work for split_table_columns_spec().

Committed the test portion for now, still reviewing the rest..
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190127133301.GA15401@paquier.xyz/2-signature.asc)
  download

view thread (35+ messages)  latest in thread

Message-ID: <20190127133301.GA15401@paquier.xyz>
Permalink:  ../20190127133301.GA15401@paquier.xyz/
Also on:    postgresql.org/message-id/20190127133301.GA15401@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, bossartn@amazon.com, sawada.mshk@gmail.com, robertmhaas@gmail.com
  Subject: Re: A few new options for vacuumdb
  In-Reply-To: <20190127133301.GA15401@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox