pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Sergei Kornilov <sk@zsrv.org>
Cc: andres@anarazel.de <andres@anarazel.de>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow online change primary_conninfo
Date: Fri, 1 Feb 2019 11:00:52 +0900
Message-ID: <20190201020052.GE2179@paquier.xyz> (raw)
In-Reply-To: <6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net>
References: <20181211052249.GB17695@paquier.xyz>
	<20027911544523224@iva4-f774db2b5297.qloud-c.yandex.net>
	<9653601544523383@iva8-37fc2ad204cd.qloud-c.yandex.net>
	<20181213.184233.215171075.horiguchi.kyotaro@lab.ntt.co.jp>
	<4926831544698308@iva3-294f9af87d55.qloud-c.yandex.net>
	<20181214075542.GG2921@paquier.xyz>
	<20190131125837.6gtbdslj5atasuoz@alap3.anarazel.de>
	<6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net>

On Thu, Jan 31, 2019 at 04:13:22PM +0300, Sergei Kornilov wrote:
> I my opinion this is not issue, database logs can have sensitive
> data. User queries, for example.  If we not want expose such info -
> it is ok just hide new value from logs with new GUC flag? Or i need
> implement masked conninfo for this purpose?

You have problems with things in this area for any commands logged and
able to show a connection string or a password, which can go down as
well to CREATE/ALTER ROLE or FDWs.  So for the purpose of what's
discussed on this thread it does not sound like a requirement to be
able to hide that.  Role DDLs can take an already-hashed input to
avoid that, still knowing the MD5 hash is sufficient for connection
(not for SCRAM!).  Now for FDWs..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (77+ messages)  latest in thread

Message-ID: <20190201020052.GE2179@paquier.xyz>
Permalink:  ../20190201020052.GE2179@paquier.xyz/
Also on:    postgresql.org/message-id/20190201020052.GE2179@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, sk@zsrv.org, andres@anarazel.de, horiguchi.kyotaro@lab.ntt.co.jp
  Subject: Re: allow online change primary_conninfo
  In-Reply-To: <20190201020052.GE2179@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox