From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jamison, Kirk <k.jamison@jp.fujitsu.com>
Cc: 'jesper.pedersen@redhat.com' <jesper.pedersen@redhat.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: fabriziomello@gmail.com <fabriziomello@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: pg_upgrade: Pass -j down to vacuumdb
Date: Fri, 1 Feb 2019 06:58:58 -0300
Message-ID: <201902010958.cf2cbi3d2ule@alvherre.pgsql> (raw)
In-Reply-To: <D09B13F772D2274BB348A310EE3027C6416F6E@g01jpexmbkw24>
On 2019-Feb-01, Jamison, Kirk wrote:
> I'm not sure if misunderstood the purpose of $VACUUMDB_OPTS. I thought what
> the other developers suggested is to utilize it so that --jobs for vacuumdb
> would be optional and just based from user-specified option $VACUUMDB_OPTS.
> By which it would not utilize the amount of jobs used for pg_upgrade.
> To address your need of needing a parallel, the script would just then
> suggest if the user wants a --jobs option. The if/else for number of jobs is
> not needed in that case, maybe only for ifndef WIN32 else case.
No Kirk, you got it right -- (some of) those ifdefs are not needed, as
adding the --jobs in the command line is not needed. I do think some
extra whitespace in the format string is needed.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, k.jamison@jp.fujitsu.com, jesper.pedersen@redhat.com, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, fabriziomello@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, bruce@momjian.us
Subject: Re: pg_upgrade: Pass -j down to vacuumdb
In-Reply-To: <201902010958.cf2cbi3d2ule@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox