From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
Date: Wed, 13 Feb 2019 16:18:29 -0300
Message-ID: <20190213191829.GA19406@alvherre.pgsql> (raw)
In-Reply-To: <CAKJS1f-ukvN_OneocD_t_e=Ky1UoNX7hnnVU5m1b=kR_7DYciw@mail.gmail.com>
On 2019-Feb-04, David Rowley wrote:
> On Fri, 1 Feb 2019 at 11:45, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > I only have cosmetic suggestions for this patch. For one thing, I think
> > the .c file should be in src/port and its header should be in
> > src/include/port/, right beside the likes of pg_bswap.h and pg_crc32c.h.
>
> I've moved the code into src/port and renamed the file to pg_bitutils.c
I've pushed this now. Let's see what the buildfarm has to say about it.
> I've compiled and run make check-world on Linux with GCC7.3 and
> clang6.0. I've also tested on MSVC to ensure I didn't break windows.
> It would be good to get a few more people to compile it and run the
> tests.
That's what the buildfarm is for ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, david.rowley@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, thomas.munro@enterprisedb.com
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
In-Reply-To: <20190213191829.GA19406@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox