From: Michael Paquier <michael@paquier.xyz>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Grigory Smolkin <g.smolkin@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] xlogreader: do not read a file block twice
Date: Mon, 18 Feb 2019 10:09:02 +0900
Message-ID: <20190218010902.GF1864@paquier.xyz> (raw)
In-Reply-To: <20190214230616.GA2240@paquier.xyz>
References: <2ddf4a32-517e-d6f4-d992-4a63b6035bfd@postgrespro.ru>
<87e30af6-f85a-dc95-4574-95cded028786@postgrespro.ru>
<20190212042300.GL1475@paquier.xyz>
<1fa0c9fe-32a5-3ebd-e9c2-b5e2c9abc03e@postgrespro.ru>
<20190214065156.GE2366@paquier.xyz>
<7eaccd53-ea89-e0cf-b718-80e3f3fc3abf@postgrespro.ru>
<20190214230616.GA2240@paquier.xyz>
On Fri, Feb 15, 2019 at 08:06:16AM +0900, Michael Paquier wrote:
> Thanks, I see what you have done. I cannot comment if your shortcut
> is actually fully correct based on my knowledge of this code, but
> things cannot be in the best conditions without having the WAL reader
> handle properly the limits. So I am planning to commit what you
> propose after an extra pass on it in the next couple of days or so.
And done, after doing and extra pass, doing more testing using by own
plugins, pg_waldump and more fancy stuff with a primary/standby and
pgbench.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190218010902.GF1864@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, a.zakirov@postgrespro.ru, g.smolkin@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] xlogreader: do not read a file block twice
In-Reply-To: <20190218010902.GF1864@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox