From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Antonin Houska <ah@cybertec.at>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Incorrect visibility test function assigned to snapshot
Date: Mon, 18 Feb 2019 10:45:38 -0300
Message-ID: <20190218134538.GA809@alvherre.pgsql> (raw)
In-Reply-To: <20190218040120.GI15532@paquier.xyz>
On 2019-Feb-18, Michael Paquier wrote:
> On Fri, Feb 15, 2019 at 01:01:29PM +0100, Antonin Houska wrote:
> > As for the bug fix, I think the additional assignment does not make things
> > worse because SnapBuildInitialSnapshot() already does overwrite some fields:
> > "xip" and "xnt".
>
> Ah, right. I somewhat missed that. Let's move on with merging your
> patch then. Are there any objections about that?
None here.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, ah@cybertec.at, bruce@momjian.us
Subject: Re: Incorrect visibility test function assigned to snapshot
In-Reply-To: <20190218134538.GA809@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox