From: Michael Paquier <michael@paquier.xyz>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: TupleTableSlot abstraction
Date: Wed, 27 Feb 2019 14:21:52 +0900
Message-ID: <20190227052152.GA3540@paquier.xyz> (raw)
In-Reply-To: <CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com>
References: <20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de>
<20181113233021.nckxp4kalaqzx7ag@alap3.anarazel.de>
<20181117004642.hushozrhxs7v72qo@alap3.anarazel.de>
<CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com>
On Sat, Feb 16, 2019 at 05:07:44PM -0500, Jeff Janes wrote:
> By blind analogy to the changes made to matview.c, I think that createas.c
> is missing a heap_freetuple, as attached.
I think that you are right. CTAS and materialized views share a lot
when it comes to relation creation and initial table loading. I have
reproduced the leak and could notice that your fix is correct. So
committed.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190227052152.GA3540@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, jeff.janes@gmail.com, andres@anarazel.de, robertmhaas@gmail.com, kommi.haribabu@gmail.com, amitdkhan.pg@gmail.com, alvherre@2ndquadrant.com, amit.kapila16@gmail.com
Subject: Re: TupleTableSlot abstraction
In-Reply-To: <20190227052152.GA3540@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox