From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: TupleTableSlot abstraction
Date: Wed, 27 Feb 2019 15:34:07 +0900
Message-ID: <20190227063407.GD3540@paquier.xyz> (raw)
In-Reply-To: <20190227054238.c7epq2so7nly5yfh@alap3.anarazel.de>
References: <20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de>
<20181113233021.nckxp4kalaqzx7ag@alap3.anarazel.de>
<20181117004642.hushozrhxs7v72qo@alap3.anarazel.de>
<CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com>
<20190227052152.GA3540@paquier.xyz>
<20190227054238.c7epq2so7nly5yfh@alap3.anarazel.de>
On Tue, Feb 26, 2019 at 09:42:38PM -0800, Andres Freund wrote:
> I'm not so sure that's the architecturally correct fix however. Is it
> actually guaranteed, given expanded tuples, toasting, etc, that there's
> no other memory leak here? I wonder if we shouldn't work twoards using a
> short lived memory context here. Note how e.g. printtup() uses a short
> lived context for its work.
Perhaps. I got to wonder if this change would not impact code using
their own DestReceiver, resulting in similar leaks when they insert
tuples on-the-fly. Such issues can be surprising for fork an plugin
developers. I was playing a bit with some refactoring of relation
creation for CTAS in the scope of temporary matviews, and noticed this
issue on the CF list, so that was a bit annoying, and issues like that
tend to be easily forgotten..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190227063407.GD3540@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, jeff.janes@gmail.com, robertmhaas@gmail.com, kommi.haribabu@gmail.com, amitdkhan.pg@gmail.com, alvherre@2ndquadrant.com, amit.kapila16@gmail.com
Subject: Re: TupleTableSlot abstraction
In-Reply-To: <20190227063407.GD3540@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox