From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Surafel Temesgen <surafel3000@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump multi VALUES INSERT
Date: Mon, 4 Mar 2019 12:46:25 -0300
Message-ID: <20190304154625.GA495@alvherre.pgsql> (raw)
In-Reply-To: <alpine.DEB.2.21.1903020730480.8095@lancre>
On 2019-Mar-02, Fabien COELHO wrote:
> Although I'm all in favor of checking the int associated to the option, I do
> not think that it warrants three checks and messages. I would suggest to
> factor them all as just one check and one (terse) message.
I suggest ("rows-per-insert must be in range 1..%d", INT_MAX), like
extra_float_digits and compression level.
> About the output: I'd suggest to indent one line per row, something like:
>
> INSERT INTO foo VALUES
> (..., ..., ..., ...),
> (..., ..., ..., ...),
> (..., ..., ..., ...);
+1.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, coelho@cri.ensmp.fr, david.rowley@2ndquadrant.com, surafel3000@gmail.com, 9erthalion6@gmail.com
Subject: Re: pg_dump multi VALUES INSERT
In-Reply-To: <20190304154625.GA495@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox