pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Fetter <david@fetter.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: psql show URL with help
Date: Thu, 7 Mar 2019 23:02:34 +0100
Message-ID: <20190307220234.GI10435@fetter.org> (raw)
In-Reply-To: <CABUevEwNHUe3mHO5QXG9J14ag=7ubbfp6-QxxAOkt+jmfg6rTg@mail.gmail.com>
References: <40179bd0-fa7d-4108-1991-a20ae9ad5667@2ndquadrant.com>
	<47e071fd-8997-f036-b383-4d80c184adeb@2ndquadrant.com>
	<a8df897e-f1df-b539-a85d-298c678d4180@2ndquadrant.com>
	<20190303181432.GA316@fetter.org>
	<CABUevEyc98E-Jxq-S5jEttiwrdxkAZbpUNsoEt5=DwgVqauY5g@mail.gmail.com>
	<20190303214833.GD10435@fetter.org>
	<CABUevEwUrZWa+8S3_mZ+6HrxUPvFjVU8Os6AKZiKa2KTGnwhQw@mail.gmail.com>
	<b8f27893-a7fb-1dd6-efe8-ca2f228b8578@2ndquadrant.com>
	<CABUevEwNHUe3mHO5QXG9J14ag=7ubbfp6-QxxAOkt+jmfg6rTg@mail.gmail.com>

On Thu, Mar 07, 2019 at 11:44:07AM -0800, Magnus Hagander wrote:
> On Mon, Mar 4, 2019 at 11:41 PM Peter Eisentraut <
> peter.eisentraut@2ndquadrant.com> wrote:
> 
> > On 2019-03-04 17:55, Magnus Hagander wrote:
> > >     If the first thing we do when we move from devel to some other state
> > >     (beta, RC, etc.) is to publish the docs under the major version
> > >     number, then maybe this test should be more along the lines of
> > looking
> > >     for anything that's neither devel nor a number, extract the number,
> > >     and use that.
> > >
> > >
> > > Well, alpha versions do go under the numeric URL. Whether we load the
> > > docs at that time or not we can just choose -- but there is no reason
> > > not to. So yeah, that sounds like it would work better.
> >
> > Can you put your proposal in the form of some logical pseudocode?  I
> > don't understand the free-form description.
> >
> 
> Hah, sorry. It's actually Davids proposal, but something like:
> 
> if (psql_version_is_numeric)
>  return /docs/psql_version/
> else if (psql_version ends with 'devel')
>   return /docs/devel/
> else
>   return /docs/{psql_version but with text stripped}/
> 
> So that e.g. 12beta would return "12", as would 12rc or 12alpha. But
> 12devel would return "devel".

That's exactly what I had in mind :)

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate




view thread (25+ messages)  latest in thread

Message-ID: <20190307220234.GI10435@fetter.org>
Permalink:  ../20190307220234.GI10435@fetter.org/
Also on:    postgresql.org/message-id/20190307220234.GI10435@fetter.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@fetter.org, magnus@hagander.net, peter.eisentraut@2ndquadrant.com
  Subject: Re: psql show URL with help
  In-Reply-To: <20190307220234.GI10435@fetter.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox